Contribute: zfs driver and zfs driver shared over ISCSI #5654
Conversation
rsmontero
force-pushed
the
master
branch
4 times, most recently
from
0b269ff
to
b94dad5
Compare
| enabled: true | ||
| actions: | ||
| change_authentication: true | ||
| update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
rsmontero
force-pushed
the
master
branch
2 times, most recently
from
9e1985e
to
d019bd4
Compare
| settings_auth_tab: true | ||
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| settings_auth_tab: true | ||
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| User.two_factor_auth: true | ||
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| settings_auth_tab: true | ||
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| settings_showback_tab: true | ||
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| User.two_factor_auth: true | ||
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| User.two_factor_auth: true | ||
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| settings_auth_tab: true | ||
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| User.two_factor_auth: true | ||
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| User.two_factor_auth: true | ||
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
* It looks like `onedb purge-history` sometimes fails to delete some history records. * Delete all history records with SEQ greater then VM/HISTORY_RECORDS/HISTORY/SEQ, which should be the last record
* Now displays hostname next to the host in the card view * Also displays hostname in the list view Signed-off-by: Victor Hansson <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>
Signed-off-by: dcarracedo <[email protected]>
Signed-off-by: dcarracedo <[email protected]>
This feature let's cloud admin to proxy VM connections to any service through the hypervisor. VMs uses a link local IP that is forwarded to a local proxy. This simplifies VM network requirements, e.g. to access gateway, vaults, configuration services etc... Implementation: - Use network namespaces to isolate VNET networking. ip netns command is executed through a wrapper to limit sudo access to commands. - Add tproxy.rb app to manage a group of daemons on HV nodes. - Use unix sockets for communication between proxy peers. "Inner" proxy runs in the netns without any network access. "Outer" proxy handles HV connections to services. - Use OpenNebulaNetwork.conf + 'onehost sync -f' for configuration. Proxy can be defined per network.
* Correctly displays the VM disks when restoring a backup from the VM action menu Signed-off-by: Victor Hansson <[email protected]>
- oned load only last 2 history records (not the full list) - Dump all history records only if needed in VirtualMachine::to_xml. - Dump conforms XML schecam and removes VM template from history records. Speed up of onevm show command: - for small SQLite DB is for VM with 500 histories: 130 ms down to 5 ms - for big MySQL DB VM with 687 histories: 1000 ms down to 200 ms
Implementation overview: - Incremental points are saved as dedicated rbd snapshots under the "one_backup_<increment_id>" namespace. This snapshots are used to generate delta files in rbdiff format. - The rbdiff formats are stored in the backup server to restore the rbd volumes. - The restore process is performed directly on the Ceph cluster importing the base image (first full backup in the chain, rbd import) and then applying the increments (rbd import-diff) up to the target increment. - Two new pseudo-protocols has been implemented to adopt the restore pattern above (restic+rbd, rsync+rbd). This protocols bundle of the rbdiff files in a tarball for transfer from the backup server. Note: reconstruct process uses the Ceph BRIDGE_LIST and not the backup server (as opposed to qcow2 backups) Other bug fixes - This commit also fixes #6741, resetting the backup chain after a restore - The original ceph drivers do not receive the full action information, this now has been fixed by including VM information in the STDIN string sent to the driver. Compatibility note. - backup actions should return now the backup format used raw, rbd, ... If not provided oned (6.10.x) will use raw as a default to accommodate any third party driver implementation. It is recommended to include this third argument. Signed-off-by: Guillermo Ramos <[email protected]> Co-authored-by: Guillermo Ramos <[email protected]>
| @@ -20,6 +20,8 @@ script_name=$(basename $0) | |||
|
|
|||
| source $(dirname $0)/../../scripts_common.sh | |||
|
|
|||
| STDIN=`cat -` | |||
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Use $(...) notation instead of legacy backticks ....
| file_type="application/octet-stream" | ||
| command="$VAR_LOCATION/remotes/datastore/docker_downloader.sh \"$FROM\"" | ||
| restic://*|restic+rbd://*) | ||
| defs=`$VAR_LOCATION/remotes/datastore/restic_downloader.rb "$FROM" | grep -e '^command=' -e '^clean_command='` |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Use $(...) notation instead of legacy backticks ....
| echo $RETRY_ARGS | ||
| } | ||
|
|
||
| TEMP=`getopt -o m:s:l:c:no -l md5:,sha1:,limit:,max-size:,nodecomp,noretry -- "$@"` |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Use $(...) notation instead of legacy backticks ....
| # Usage: | ||
| # verlte "3.2.9" "3.4.0" | ||
| function verlte() { | ||
| [ "$1" = "`echo -e "$1\n$2" | sort -V | head -n1`" ] |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Use $(...) notation instead of legacy backticks ....
| eval "$defs" | ||
| ;; | ||
| rsync://*|rsync+rbd://*) | ||
| defs=`$VAR_LOCATION/remotes/datastore/rsync_downloader.rb "$FROM" | grep -e '^command=' -e '^clean_command='` |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Use $(...) notation instead of legacy backticks ....
| # .monitor file containing the $3 ( the driver name) (e.g ssh) | ||
| function enable_local_monitoring | ||
| { | ||
| SSH_EXEC_ERR=`$SSH $1 bash -s 2>&1 1>/dev/null <<EOF |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Use $(...) notation instead of legacy backticks ....
|
|
||
| RETRY_ARGS="--retry 3 --retry-delay 3" | ||
|
|
||
| CURL_VER=`curl --version | grep -o 'curl [0-9\.]*' | awk '{print $2}'` |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Use $(...) notation instead of legacy backticks ....
| # .monitor file | ||
| function disable_local_monitoring | ||
| { | ||
| SSH_EXEC_ERR=`$SSH $1 bash -s 2>&1 1>/dev/null <<EOF |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Use $(...) notation instead of legacy backticks ....
Signed-off-by: Victor Hansson <[email protected]>
to contain layout information Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>
- Incremental backups only keep the last snapshot, to be used as base in the next one. - Restore operation deletes the previous snapshots, because at that point the chain is reset and they're no longer going to be used. - Starting a new FULL backup also deletes previous inc snapshots. - Refactor the remote execution logic to make it more composable. Signed-off-by: Guillermo Ramos <[email protected]> (cherry picked from commit 1790b5f3f9ac55e3149f5344580330c27d5585df)
- Ensure sockets are always closed properly. - Normalize and cleanup nft scripts (to prevent potential segfaults).
Signed-off-by: Victor Hansson <[email protected]>
in user inputs Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>
Signed-off-by: Victor Hansson <[email protected]>
Signed-off-by: Victor Hansson <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>
Signed-off-by: Victor Hansson <[email protected]>
when the $ISO_PATH is a block device (cherry picked from commit bf43d43)
I make available my integration work on zfs, based on the ceph driver.
zfs is for single node and zfs_iscsi for shared
https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git